Skip to content

Optics - Fix vanilla mRad reticles calibration at vanilla magnifications.#11062

Merged
PabstMirror merged 5 commits intoacemod:masterfrom
Laid3acK:mrad_vanilla_scopes
Sep 23, 2025
Merged

Optics - Fix vanilla mRad reticles calibration at vanilla magnifications.#11062
PabstMirror merged 5 commits intoacemod:masterfrom
Laid3acK:mrad_vanilla_scopes

Conversation

@Laid3acK
Copy link
Copy Markdown
Contributor

@Laid3acK Laid3acK commented Sep 20, 2025

When merged this pull request will:

  • Fix vanilla LRPS, AMS, Kahlia and Kahlia (Old) mRad reticles calibration at vanilla magnifications.
  • Fix vanilla LRPS, AMS, Kahlia and Kahlia (Old) background circle incorrectly centered (scope_view4_ca.paa).
  • Fix vanilla LRPS reticles incorrectly centered (reticle_lrps_ca.paa, reticle_lrps_z_ca.paa).

LRPS 6x: vanilla, ACE3 / 25x: vanilla, ACE3

AMS 3x: vanilla, ACE3 / 10x: vanilla, ACE3

Kahlia 5x: vanilla, ACE3 / 11x: vanilla, ACE3

Tested in-game Aspect Ratio 16:9 only (default fovTop, fovLeft).
Kudos to commy2 and the CBA Debug Reticle script.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

class OpticsModes {
class Snip;
class Snip {
modelOptics[] = {"\z\ace\addons\optics\models\ld3k_reticle_lrps_F", "\z\ace\addons\optics\models\ld3k_reticle_lrps_z_F"};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
modelOptics[] = {"\z\ace\addons\optics\models\ld3k_reticle_lrps_F", "\z\ace\addons\optics\models\ld3k_reticle_lrps_z_F"};
modelOptics[] = {QPATHTOF(models\ld3k_reticle_lrps_F), QPATHTOF(models\ld3k_reticle_lrps_z_F)};

@PabstMirror PabstMirror added this to the 3.20.1 milestone Sep 21, 2025
@PabstMirror PabstMirror added the kind/change Release Notes: **CHANGED:** label Sep 21, 2025
@PabstMirror
Copy link
Copy Markdown
Contributor

Just wondering if the the difference was because of mils vs mrad
although it doesn't explain the center/offset being wrong

Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a vanilla issue, but unlikely to be fixed so I think it's reasonable for us to fix

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Sep 21, 2025

These look good @Laid3acK !
Is your new AMS BDC reticle calibrated to a specific vanilla ammo?

I'll check these on a 21:9 monitor in a day or two to see how it looks at that aspect

@Laid3acK
Copy link
Copy Markdown
Contributor Author

Laid3acK commented Sep 22, 2025

Is your new AMS BDC reticle calibrated to a specific vanilla ammo?

?
No BDC reticle, vanilla AMS FFP (First Focal Plane) reticles calibrated as it should be, according to US Optics Mil / mRad GAP reticle.

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Sep 22, 2025

Is your new AMS BDC reticle calibrated to a specific vanilla ammo?

? No BDC reticle, vanilla AMS FFP (First Focal Plane) reticles calibrated as it should be, according to US Optics Mil / mRad GAP reticle.

My bad, I was thinking the verticle numbering was in meters for some reason

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented Sep 22, 2025

They all look good in 21:9

@PabstMirror PabstMirror merged commit aff411a into acemod:master Sep 23, 2025
3 checks passed
@Laid3acK Laid3acK deleted the mrad_vanilla_scopes branch September 24, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/change Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants