Skip to content

vehicleDamage - Change fnc_processHit AP Damage Reduction#10993

Merged
PabstMirror merged 9 commits intoacemod:masterfrom
lambdatiger:vehicleDamageFix
Jul 11, 2025
Merged

vehicleDamage - Change fnc_processHit AP Damage Reduction#10993
PabstMirror merged 9 commits intoacemod:masterfrom
lambdatiger:vehicleDamageFix

Conversation

@lambdatiger
Copy link
Copy Markdown
Contributor

@lambdatiger lambdatiger commented Jun 27, 2025

When merged this pull request will:

  • Changes _addedDamage modification to work as a function of a very rough estimation of time of flight.
    • Current implementation relies on _airFriction * _distance resulting in large reductions in damage for projectiles with non-infinitesimal "airFriction" values. i.e., RHS uses penetrators for their AP ammo with airFriction of -0.08 resulting in shots at 200m applying ~1e-7 damage
    • This doesn't account for projectile bounces or deflections, but neither did the old method.
    • Previous version reduced damage by typically by ~5% for typical AP projectiles at 1km, this results in damage reduction from 10% to 30% for typical AP projectiles at 1km

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@lambdatiger
Copy link
Copy Markdown
Contributor Author

Pulling this to a draft until I experiment with a few things to better estimate speed & time of flight.

@lambdatiger lambdatiger marked this pull request as draft June 27, 2025 18:09
@lambdatiger lambdatiger marked this pull request as ready for review June 30, 2025 20:54
@lambdatiger
Copy link
Copy Markdown
Contributor Author

Still not super happy using typical speed instead of the actual initial speed to calculate approximate speed at impact, but without guessing which magazine to use (and the lookup overhead) there's not a great approach.

further clarified comment
@lambdatiger
Copy link
Copy Markdown
Contributor Author

If only we received the projectile instead of the classname from the "handleDamage" EH.

clarified comments further
@veteran29 veteran29 self-requested a review July 1, 2025 18:56
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror added this to the 3.20.0 milestone Jul 8, 2025
@PabstMirror PabstMirror added the kind/change Release Notes: **CHANGED:** label Jul 8, 2025
@PabstMirror PabstMirror merged commit 704584d into acemod:master Jul 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/change Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants