Skip to content

Medical Treatment - Enhanced Setting: Add option to allow Self-Stitch/PAK/IV only for Doctors#10962

Merged
PabstMirror merged 3 commits intoacemod:masterfrom
OverlordZorn:treatment-self-treatment-doctors-only
Jun 21, 2025
Merged

Medical Treatment - Enhanced Setting: Add option to allow Self-Stitch/PAK/IV only for Doctors#10962
PabstMirror merged 3 commits intoacemod:masterfrom
OverlordZorn:treatment-self-treatment-doctors-only

Conversation

@OverlordZorn
Copy link
Copy Markdown
Contributor

@OverlordZorn OverlordZorn commented Jun 16, 2025 •
edited
Loading

When merged this pull request will:

fn_canTreat.sqf

  • Enhanced handling of the allowSelfTreatment property:
    • New Case: 2
      • Requires Medic to be a Doctor to perform Self Treatment

initSettings.inc.sqf

  • Added selectable Option, limiting selfstitching to only doctors.
    • Updated QGVAR(allowSelfStitch) Setting
    • Updated QGVAR(allowSelfPAK) Setting
    • Updated QGVAR(allowSelfIV) Setting

Notes

  • I dont know if there's a better way to handle the check in fn_canTreat.sqf. Open to suggestions.
  • For the moment, i only used existing Stringtable entries. The setting: Allow Self-Stitching currently says No, Yes, Doctors.
    • Can upgrade to No, Yes, Doctors Only if needed but would require new stringtable entry.

@OverlordZorn OverlordZorn changed the title Medical Treatment - Updated Setting: Allow Self Stitching only for Doctors Medical Treatment - Enhanced Setting: Add option to allow Self Stitching only for Doctors Jun 16, 2025
@OverlordZorn OverlordZorn marked this pull request as ready for review June 16, 2025 08:41
LinkIsGrim
LinkIsGrim approved these changes Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving code as it is, scope is debatable IMO

@Andx667
Copy link
Copy Markdown
Contributor

Andx667 commented Jun 16, 2025 •
edited
Loading

Edit: rephrase

imho this setting should in the future also apply to the other "selfX" Treatment Settings.

@rautamiekka
Copy link
Copy Markdown
Contributor

rautamiekka commented Jun 16, 2025

imho this should be extendet to selfIV, selfPAK in addition to selfStitch. Use case would to be to have someone to be able to heal himself fully (unless he is uncon ofc). Also makes little sense to me to have the setting for stitch, but not for iv and pak since they are so similiar otherwise.

or reject.

Just add the features, it ain't exactly hard to add them, and leave the decision to use them to the Players.

@OverlordZorn OverlordZorn changed the title Medical Treatment - Enhanced Setting: Add option to allow Self Stitching only for Doctors Medical Treatment - Enhanced Setting: Add option to allow Self-Stitch/PAK/IV only for Doctors Jun 17, 2025
@OverlordZorn
Copy link
Copy Markdown
Contributor Author

OverlordZorn commented Jun 17, 2025

Added new setting entries also to SelfPAK and SelfIV

@PabstMirror PabstMirror added this to the 3.20.0 milestone Jun 17, 2025
@PabstMirror PabstMirror added the kind/setting Release Notes: **SETTINGS:** label Jun 17, 2025
@PabstMirror PabstMirror merged commit 44eda5e into acemod:master Jun 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees

No one assigned

Labels

kind/setting Release Notes: **SETTINGS:**

Projects

None yet

Milestone

3.20.0

Development

Successfully merging this pull request may close these issues.

5 participants

@OverlordZorn @Andx667 @rautamiekka @PabstMirror @LinkIsGrim