Skip to content

General - Make separate subaddons for arsenal configs#10953

Closed
johnb432 wants to merge 1 commit intomasterfrom
misc-add-arsenal-subaddons
Closed

General - Make separate subaddons for arsenal configs#10953
johnb432 wants to merge 1 commit intomasterfrom
misc-add-arsenal-subaddons

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 commented Jun 10, 2025

When merged this pull request will:

Game works perfectly fine without this PR, so technically no need to address it, but imo it's better.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Jun 10, 2025

could also just do

class EGVAR(arsenal,stats) {
    class statBase;
    class GVAR(tripods): statBase {

->

class EGVAR(arsenal,stats) {
    class statBase {};
    class GVAR(tripods): statBase {

@PabstMirror PabstMirror mentioned this pull request Jun 11, 2025
Merged
@johnb432 johnb432 closed this Jun 19, 2025
@johnb432 johnb432 deleted the misc-add-arsenal-subaddons branch June 20, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnb432 @PabstMirror