Missile Guidance - Fix SACLOS on sub-turrets#10939
Merged
PabstMirror merged 1 commit intomasterfrom Jun 23, 2025
Merged
Conversation
Contributor
|
good lord thank you for figuring this out. does this regress existing weapons? how does it work in multiplayer when non-local/moving the vehicle? |
Contributor
Author
|
tested on 2-client mp and it worked fine |
TheCandianVendingMachine
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g. GM BMP-1P
the saclos is fired from a sub-turret from the main
[0,0]so we need to take into account the animation of both turrets
CBA_fnc_turretDirseems to be ok for thisIIRC it isn't as accurate as using the raw anim, but seems to do a reasonably good job