Wardrobe - Compats: RHS USAF#10914
Closed
OverlordZorn wants to merge 357 commits intoacemod:masterfrom
Closed
Conversation
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
Since there appeared to be more items which needed some sort of config adjustment, might as well merge these into the normal compats as well
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
rautamiekka
suggested changes
Jun 5, 2025
| There *might* be some changes coming from BI regarding how arma handles the `setUnitLoadout` which could resolve the need for this. | ||
|
|
||
| ## 6.2 Container Size - Uniform, Vest, Backpack | ||
| When the player changes from one container item to another through the wardrobe action and the container's `maximumLoad` is smaller then previously, the player risks the loss of items carried inside said container. |
Contributor
There was a problem hiding this comment.
Suggested change
| When the player changes from one container item to another through the wardrobe action and the container's `maximumLoad` is smaller then previously, the player risks the loss of items carried inside said container. | |
| When the player changes from one container item to another through the wardrobe action and the container's `maximumLoad` is smaller than previously, the player risks the loss of items carried inside said container. |
Contributor
Author
There was a problem hiding this comment.
please make those change requests on the main wardrobe PR
|
|
||
| If an addon or mod utilizes a magazine's `magazineID` to handle additional data about items carried by the player, then the process of modifying a wearable container (uniform, vest, backpack) to another variant will result in new `magazineID`s for all magazines on the player and therefore, require special handling within `ace_wardrobe` functions. | ||
|
|
||
| There *might* be some changes coming from BI regarding how arma handles the `setUnitLoadout` which could resolve the need for this. |
Contributor
There was a problem hiding this comment.
Suggested change
| There *might* be some changes coming from BI regarding how arma handles the `setUnitLoadout` which could resolve the need for this. | |
| There *might* be some changes coming from BI regarding how Arma handles the `setUnitLoadout` which could resolve the need for this. |
Contributor
Author
There was a problem hiding this comment.
please make those change requests on the main wardrobe PR
|
|
||
| #### 2.2.5 Base Helmet Visor Up / Down | ||
| Common base class for helmets with a visor that can be flipped up or down. | ||
| Here, the duration is carefully timed to be aligned with the "click" of the soun. |
Contributor
There was a problem hiding this comment.
Suggested change
| Here, the duration is carefully timed to be aligned with the "click" of the soun. | |
| Here, the duration is carefully timed to be aligned with the "click" of the sound. |
Contributor
Author
There was a problem hiding this comment.
please make those change requests on the main wardrobe PR
Comment on lines
+40
to
+41
| | Class Property | Data Type | Description | | ||
| | -------------- | ----------- | ----------- | |
Contributor
There was a problem hiding this comment.
Just for consistency, as the end result seems to still work just fine even without.
Suggested change
| | Class Property | Data Type | Description | | |
| | -------------- | ----------- | ----------- | | |
| | Class Property | Data Type | Description | | |
| | -------------- | --------- | ----------- | |
Contributor
Author
There was a problem hiding this comment.
please make those change requests on the main wardrobe PR
|
|
||
| The Wardrobe addon gives the player the opportunity to change/modify their current wearables into different variants. | ||
|
|
||
| For example, if a uniform has a normal variant and a "rolled-Up sleeves" variant, the player will be able to use ether an ACE Self Interaction or the CBA Context Menu in the inventory. |
Contributor
There was a problem hiding this comment.
Suggested change
| For example, if a uniform has a normal variant and a "rolled-Up sleeves" variant, the player will be able to use ether an ACE Self Interaction or the CBA Context Menu in the inventory. | |
| For example, if a uniform has a normal variant and a "rolled-up sleeves" variant, the player will be able to use ether an ACE Self Interaction or the CBA Context Menu in the inventory. |
Contributor
Author
There was a problem hiding this comment.
please make those change requests on the main wardrobe PR
| <English>Put goggles on</English> | ||
| </Key> | ||
| <Key ID="STR_ACE_Wardrobe_jacketClose"> | ||
| <English>Close Jacket</English> |
Contributor
There was a problem hiding this comment.
For consistency.
Suggested change
| <English>Close Jacket</English> | |
| <English>Close jacket</English> |
Contributor
Author
There was a problem hiding this comment.
please make those change requests on the main wardrobe PR
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
…nto ace-wardrobe
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Wardrobe Compats for RHS GREF
Requires
#10606
Contributer
@Andx667