Skip to content

Misc. compats - Exclude some MLRS vehicles from own backblast#10896

Merged
PabstMirror merged 2 commits intomasterfrom
overpressure-disable-mlrs
May 6, 2025
Merged

Misc. compats - Exclude some MLRS vehicles from own backblast#10896
PabstMirror merged 2 commits intomasterfrom
overpressure-disable-mlrs

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 commented May 3, 2025

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label May 3, 2025
@johnb432 johnb432 added this to the 3.20.0 milestone May 3, 2025
@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented May 3, 2025

Would it make sense to always exclude the vehicle from backblast when turret elevation is higher than a specific amount?

if (_vehicle != _shooter && {getNumber (configOf _vehicle >> QGVAR(noReflection)) == 1}) exitWith {};

[_vehicle, _vehicle unitTurret _shooter, false] call CBA_fnc_turretDir select 1 > 45

@johnb432
Copy link
Copy Markdown
Contributor Author

johnb432 commented May 5, 2025

Would it make sense to always exclude the vehicle from backblast when turret elevation is higher than a specific amount?

if (_vehicle != _shooter && {getNumber (configOf _vehicle >> QGVAR(noReflection)) == 1}) exitWith {};

[_vehicle, _vehicle unitTurret _shooter, false] call CBA_fnc_turretDir select 1 > 45

Honestly, not sure - I'm a little hesitant.

@Drofseh
Copy link
Copy Markdown
Contributor

Drofseh commented May 6, 2025

Honestly, not sure - I'm a little hesitant.

I'm not 100% sure what would be best either, but I think if the vehicle is backed up against a wall and fires relatively horizontally it shouldn't be exempt from reflections.

Maybe change the angle of the overpreassure cone based on the elevation so it's still largely going backwards?
That would hopefully avoid it coming forward to hit the crew.

@PabstMirror
Copy link
Copy Markdown
Contributor

I think PR is good to go as is, maybe continue to look in a follow up?

@PabstMirror PabstMirror merged commit 4695bae into master May 6, 2025
3 checks passed
@PabstMirror PabstMirror deleted the overpressure-disable-mlrs branch May 6, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overpressure/Backblast makes artillery unusable

3 participants