Overheating - fix/improve ace_overheating_fnc_jamWeapon#10873
Merged
Drofseh merged 6 commits intoacemod:masterfrom Apr 28, 2025
Drofseh:Overheating-improve-fnc_jamWeapon
Merged
Overheating - fix/improve ace_overheating_fnc_jamWeapon#10873Drofseh merged 6 commits intoacemod:masterfrom Drofseh:Overheating-improve-fnc_jamWeapon
Drofseh merged 6 commits intoacemod:masterfrom
Drofseh:Overheating-improve-fnc_jamWeapon
Conversation
rautamiekka
suggested changes
Apr 20, 2025
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
johnb432
reviewed
Apr 23, 2025
rautamiekka
suggested changes
Apr 24, 2025
johnb432
approved these changes
Apr 27, 2025
Contributor
johnb432
left a comment
There was a problem hiding this comment.
I'll open another PR with some more changes, such as renaming _zero and _one to meaningful names.
This PR, as is - LGTM.
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
for "_i" from count _jamTypesAllowedsteps, should only have returned the strings like "Feed" but was returning numbers as well and therefore always failing theif !(_jamCurretType in ["eject", etc]check and falling back to default .