Repair - Patch to detect GM Wheel position and selection#10871
Merged
PabstMirror merged 2 commits intoacemod:masterfrom Apr 25, 2025
Merged
Repair - Patch to detect GM Wheel position and selection#10871PabstMirror merged 2 commits intoacemod:masterfrom
PabstMirror merged 2 commits intoacemod:masterfrom
Conversation
PabstMirror
approved these changes
Apr 23, 2025
Contributor
|
The motor cycle has scuffed wheel interaction points, but I'm assuming that it was already problematic before this PR. Good job, finding a solution to this problem was desperately needed. |
Contributor
Author
I saw that too, but didn't want to start putting even further special cases to handle it, and thanks, I hope it isn't too jank. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ace_common_fnc_getWheelHitPointsWithSelectionsto find GM wheels and a selection that does not disappear when wheel damage is one / the wheel proxy goes away.Open to any feedback on how to make this less jank. I don't think anyone else uses proxies for wheels besides GM devs, so I only check for their work (they set a config flag on top of the DLC config entry).
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.