Refuel - Improved: Added Soundeffects#10825
Conversation
https://github.com/acemod/ACE3/blob/1e404cf85b2af8ad575c5f053fe0205e9ffa2470/addons/repair/functions/fnc_isEngineer.sqf This function is public api, this here should be too
This reverts commit ed96e36.
|
Did you record these yourself or are these licensed? |
they're from freesound.org, author and cc should be baked into the soundfile. Stop:
Start:
|
|
Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds: |
will do - wasnt sure how else to do it! |
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
when people walk away and walk back, the sound remains active instead of being dropped due to being out of range.
5748250 to
5ed41a7
Compare
|
I don't think it needs to go in authors, just license, unless I am wrong |
the fastroping sounds are in there, thats why i added them Line 182 in a82d5a4 |
johnb432
left a comment
There was a problem hiding this comment.
LGTM for next CBA release.
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Once this is merged i can make another pr to remove the lines if needed |
When merged this pull request will:
IMPORTANT
Requires CBATeam/CBA_A3#1751