Skip to content

Refuel - Improved: Added Soundeffects#10825

Merged
PabstMirror merged 18 commits intoacemod:masterfrom
OverlordZorn:refuel_soundeffects
May 11, 2025
Merged

Refuel - Improved: Added Soundeffects#10825
PabstMirror merged 18 commits intoacemod:masterfrom
OverlordZorn:refuel_soundeffects

Conversation

@OverlordZorn
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Adds Soundeffect to Refuel Start
  • Adds Soundeffect to Refuel Stopped

IMPORTANT

Requires CBATeam/CBA_A3#1751

@OverlordZorn
Copy link
Copy Markdown
Contributor Author

@BaerMitUmlaut
Copy link
Copy Markdown
Member

Did you record these yourself or are these licensed?

@OverlordZorn
Copy link
Copy Markdown
Contributor Author

Did you record these yourself or are these licensed?

they're from freesound.org, author and cc should be baked into the soundfile.

Stop:
https://freesound.org/people/joedeshon/sounds/117419/

You can copy, modify, distribute and perform the sound, even for commercial purposes, all without the need of asking permission to the author.

Start:
https://freesound.org/people/WryFighter/sounds/451551/

You are free to share (to copy, distribute and transmit) and to remix (to adapt and modify) as long as you credit the author of the sound.

@BaerMitUmlaut
Copy link
Copy Markdown
Member

Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds:

@OverlordZorn
Copy link
Copy Markdown
Contributor Author

Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds:

* https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/LICENSE#L30

* https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/addons/fastroping/data/sounds/LICENSE.md

will do - wasnt sure how else to do it!

PabstMirror and others added 9 commits March 26, 2025 12:48
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
when people walk away and walk back, the sound remains active instead of being dropped due to being out of range.
@PabstMirror PabstMirror added target/next-cba kind/enhancement Release Notes: **IMPROVED:** labels Mar 27, 2025
@PabstMirror PabstMirror added this to the Ongoing milestone Mar 27, 2025
@BrettMayson
Copy link
Copy Markdown
Member

BrettMayson commented Apr 3, 2025

I don't think it needs to go in authors, just license, unless I am wrong

@OverlordZorn
Copy link
Copy Markdown
Contributor Author

OverlordZorn commented Apr 3, 2025

I don't think it needs to go in authors, just license, unless I am wrong

the fastroping sounds are in there, thats why i added them

Tessa Elieff <Fastroping Sound - CreativeCommons Attributions 3.0>

Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for next CBA release.

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@OverlordZorn
Copy link
Copy Markdown
Contributor Author

  • exit 3x implemented
  • comment 3x "TODO"

Once this is merged i can make another pr to remove the lines if needed

@PabstMirror PabstMirror merged commit 534687e into acemod:master May 11, 2025
3 checks passed
@OverlordZorn OverlordZorn deleted the refuel_soundeffects branch May 11, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants