Artillery Tables - Don't block zeroing for turrets without elevationMode#10810
Merged
PabstMirror merged 2 commits intomasterfrom Apr 1, 2025
Merged
Artillery Tables - Don't block zeroing for turrets without elevationMode#10810PabstMirror merged 2 commits intomasterfrom
elevationMode#10810PabstMirror merged 2 commits intomasterfrom
Conversation
rautamiekka
suggested changes
Mar 17, 2025
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
LinkIsGrim
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://discord.com/channels/105462288051380224/122121444703338496/1350954562466480249
For turrets not using an elevation mode (i.e. mouse controls elevation instead of pageUp/Down)
Show the info 1 step below, so it doesn't block vanilla ranging (discreteDistance)
vanilla zeroing will have a negative effect, so it's best to range as low as possible
Could possibly handle the vanilla zeroing, but it would be a lot of work for something pretty uncommon
just range 100 and it's very close