Medical Damage - Pass ammo to wound handlers#10573
Merged
LinkIsGrim merged 9 commits intomasterfrom Feb 8, 2025
Merged
Conversation
PabstMirror
reviewed
Dec 19, 2024
3 tasks
PabstMirror
reviewed
Dec 19, 2024
LinkIsGrim
commented
Dec 20, 2024
johnb432
reviewed
Feb 8, 2025
johnb432
reviewed
Feb 8, 2025
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
approved these changes
Feb 8, 2025
johnb432
reviewed
Feb 9, 2025
|
|
||
| // If invalid return, log an error and exit | ||
| if (isNil "_damageData" || {!(_damageData isEqualType [])} || {(count _damageData) < _originalCount}) then { | ||
| ERROR_2("Return for handler '%1' invalid - '%2', skipping wound handling",_damageData,_handlerName); |
Contributor
There was a problem hiding this comment.
@LinkIsGrim This is now throwing
12:19:40 [ACE] (medical_damage) ERROR: Return for handler '[]' invalid - 'ace_medical_damage', skipping wound handling, need to find a solution to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Potentially breaking change, added note on wiki on best practice, should have a warning on release announcement.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.