Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

Add withRenderProps#663

Merged
istarkov merged 1 commit intoacdlite:masterfrom
pomber:master
May 10, 2018
Merged

Add withRenderProps#663
istarkov merged 1 commit intoacdlite:masterfrom
pomber:master

Conversation

@pomber
Copy link
Copy Markdown
Contributor

@pomber pomber commented May 4, 2018

From this tweet. Let me know if there's anything missing.

@istarkov
Copy link
Copy Markdown
Contributor

istarkov commented May 4, 2018

Super! Thank you, I will check at sunday|monday, seems like travis is broken now.

@wuct
Copy link
Copy Markdown
Contributor

wuct commented May 5, 2018

Is TravisCI broken now?

@istarkov
Copy link
Copy Markdown
Contributor

istarkov commented May 5, 2018

see log: command "eval yarn " failed
rebuild doesnt help

Copy link
Copy Markdown
Contributor

@wuct wuct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istarkov istarkov merged commit 3330337 into acdlite:master May 10, 2018
@istarkov
Copy link
Copy Markdown
Contributor

Thanks, Ill add flowtypings and make release.

@renatorib
Copy link
Copy Markdown

renatorib commented May 21, 2018

Like it!! It's great

@sylvain-hamel
Copy link
Copy Markdown

What are the use cases and benefits of withRenderProps? I asked this question on SO but did not get any answer. I understand the render prop pattern. What I'd like to know is when/why I would convert some of recompose's HOCs (or my own HOCs) this way, using withRenderProps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants