This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Pass blacklist argument to hoist-non-react-statics using hoistStatics#632
Merged
wuct merged 1 commit intoacdlite:masterfrom Mar 26, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 49 49
Lines 367 367
=======================================
Hits 324 324
Misses 43 43
Continue to review full report at Codecov.
|
Contributor
|
Just curious is it possible to use hoist-non-react-statics instead of current implementation, may be we should deprecate current and recommend use 3rd party lib instead of trying to make current implementation similar to it. As it do one thing and do it well? |
Contributor
|
oops we already use it ;-) |
Contributor
|
@wuct I see nothing bad here |
Contributor
|
LGTM. Thank you! |
Contributor
|
@pex Can you kindly update the API doc as well? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hoist-non-react-statics supports an undocumented argument
blacklistin order to blacklist static properties that shall not be copied.This PR adds that option to
recompose/hoistStatics.