Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

Object Rest/Spread compliance#627

Merged
wuct merged 1 commit intoacdlite:masterfrom
henryqdineen:patch-2
Mar 19, 2018
Merged

Object Rest/Spread compliance#627
wuct merged 1 commit intoacdlite:masterfrom
henryqdineen:patch-2

Conversation

@henryqdineen
Copy link
Copy Markdown
Contributor

@henryqdineen henryqdineen commented Mar 15, 2018

This is an error I ran into while statically analyzing this code.

In newer versions of babylon it will error if the rest param is not the end when desctructuring.

See here: https://github.com/babel/babylon/blob/master/CHANGELOG.md#eyeglasses-spec-compliancy-6

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files          49       49           
  Lines         367      367           
=======================================
  Hits          324      324           
  Misses         43       43
Impacted Files Coverage Δ
src/packages/recompose/nest.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b63cde...4fe2f27. Read the comment docs.

@wuct
Copy link
Copy Markdown
Contributor

wuct commented Mar 19, 2018

Thanks!

@wuct wuct merged commit 47f4794 into acdlite:master Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants