This repository was archived by the owner on Sep 10, 2022. It is now read-only.
add lifecycle example in docs#564
Merged
wuct merged 1 commit intoacdlite:masterfrom Nov 20, 2017
pokorson:add_lifecyle_example
Merged
add lifecycle example in docs#564wuct merged 1 commit intoacdlite:masterfrom pokorson:add_lifecyle_example
wuct merged 1 commit intoacdlite:masterfrom
pokorson:add_lifecyle_example
Conversation
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 49 49
Lines 370 370
=======================================
Hits 327 327
Misses 43 43Continue to review full report at Codecov.
|
Contributor
|
You are right. |
Author
|
@wuct will you consider merging just doc example? |
wuct
suggested changes
Nov 19, 2017
Contributor
wuct
left a comment
There was a problem hiding this comment.
Just do some linting and I'll merge it.
docs/API.md
Outdated
|
|
||
| Example: | ||
| ```js | ||
| const PostsList = ({posts}) => ( |
| componentDidMount() { | ||
| API.fetchPosts().then(posts => { | ||
| this.setState({posts: posts}); | ||
| }) |
Contributor
There was a problem hiding this comment.
fetchPosts().then(posts => {
this.setState({ posts });
})
Author
|
@wuct fixed |
wuct
approved these changes
Nov 20, 2017
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
What do you think about adding example for
lifecycleusage. When I first used it, it wasn't clear that I should usethisinside spec methods.Also is there a reason for defining
lifecyclelike this? It feels strange to usethisin all this functional composition. I was thinking if it would be better if spec functions would get props and somesetStateequivalent method as arguments? It will increase API surface but I think it would be more consistent with other methods.