Support "media" argument of wp_enqueue_style#28
Closed
mundschenk-at wants to merge 15 commits intoacarbone:masterfrom
Closed
Support "media" argument of wp_enqueue_style#28mundschenk-at wants to merge 15 commits intoacarbone:masterfrom
mundschenk-at wants to merge 15 commits intoacarbone:masterfrom
Conversation
Conflicts: .project
Conflicts: AssetsMinifyInit.php plugin.php
Owner
|
Hi Peter, thanks for the pull request. I'll close this without merging because I will include this enhancement in the next version of the plugin that has been completely rewritten. Btw I've considered some of the business logic you've written, so I'm going to include you among the contributors list of the plugin (not author - different meanings). |
Author
|
Thanks! I'm looking forward to the new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make AssetsMinify honor the "media" argument of wp_enqueue_style instead of always defaulting to "screen, projection" for the minified stylesheets.