Skip to content

Handle object-shaped not schemas without crashing#1803

Merged
js2me merged 2 commits into
acacode:mainfrom
morgan-coded:fix/1798-not-object-schema
Jun 30, 2026
Merged

Handle object-shaped not schemas without crashing#1803
js2me merged 2 commits into
acacode:mainfrom
morgan-coded:fix/1798-not-object-schema

Conversation

@morgan-coded

@morgan-coded morgan-coded commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

A not: {} schema could reach the complex schema parser and crash because the parser expected complex keyword values to be arrays.

This adds array guards for complex keyword parsing, so non-array values take the same empty-result path as before while array-valued oneOf, anyOf, and allOf behavior stays unchanged. I checked the issue repro against the failing path, then ran install, format, build, and the full test suite with 275 tests passing.

Fixes #1798

Copilot AI review requested due to automatic review settings June 29, 2026 20:28
@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 21995af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
swagger-typescript-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@js2me

js2me commented Jun 30, 2026

Copy link
Copy Markdown
Member

@morgan-coded hello hello!!!!
Please add changeset pnpm changeset

@js2me

js2me commented Jun 30, 2026

Copy link
Copy Markdown
Member

@morgan-coded thank you for your contribution!!!

@js2me js2me merged commit 7bd2b17 into acacode:main Jun 30, 2026
5 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

swagger-typescript-api crashes on OpenAPI not: {} in 13.12.2, while 13.0.28 succeeds

3 participants