This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Add SANs option#27
Merged
Merged
Conversation
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
suggested changes
Oct 14, 2024
Comment on lines
+46
to
+47
| net.ParseIP("192.168.100.4"), | ||
| net.ParseIP("164.90.178.85"), |
Contributor
There was a problem hiding this comment.
Load both DNS names and IP addresses from the config, we can't have it hardcoded like this.
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
suggested changes
Oct 14, 2024
| organizational_unit: | ||
| - "AbstractMachines_ca" | ||
| country: | ||
| - "Sirbea" |
Contributor
There was a problem hiding this comment.
Sirbea is not a country, and it should be France.
Comment on lines
+143
to
+146
| config, err := LoadConfig(configFile) | ||
| if err != nil { | ||
| return &svc, err | ||
| } |
Contributor
There was a problem hiding this comment.
Load config in the main.go and use it as a param in NewService.
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
suggested changes
Oct 14, 2024
| return nil | ||
| } | ||
|
|
||
| func parseIPs(ipStrings []string) []net.IP { |
Contributor
There was a problem hiding this comment.
Extract config and config handling to a separate file. Make config IP list net.IP instead of strings and parse during config creation.
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
suggested changes
Oct 14, 2024
| dns_names: | ||
| - "localhost" | ||
| ip_addresses: | ||
| - "192.168.100.4" |
Contributor
There was a problem hiding this comment.
Suggested change
| - "192.168.100.4" | |
| - "localhost" |
| - "localhost" | ||
| ip_addresses: | ||
| - "192.168.100.4" | ||
| - "164.90.178.85" |
Contributor
There was a problem hiding this comment.
belongs to prism, don't set in this config, but rather create a config file on prism side
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
suggested changes
Oct 14, 2024
Comment on lines
+11
to
+18
| province: | ||
| - "Sirbea" | ||
| locality: | ||
| - "Sirbea" | ||
| street_address: | ||
| - "Sirbea" | ||
| postal_code: | ||
| - "Sirbea" |
Contributor
There was a problem hiding this comment.
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
approved these changes
Oct 14, 2024
dborovcanin
approved these changes
Oct 14, 2024
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds SANs option.
What does this do?
It adds SANs option for root and intermediate CA.
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
N/A
Did you document any new/modified features?
N/A
Notes