This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Fix issue cert response#23
Merged
Merged
Conversation
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
suggested changes
Sep 27, 2024
| SerialNumber string `json:"serial_number"` | ||
| SerialNumber string `json:"serial_number"` | ||
| Certificate string `json:"certificate,omitempty"` | ||
| Key string `json:"key,omitempty"` |
Contributor
There was a problem hiding this comment.
Let's remove the key from issueResponse.
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the following functionality: it updates the issue cert method to return a certificate.
What does this do?
It updates issue cert to return a certificate.
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
Yes.
Did you document any new/modified features?
N/A
Notes