This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Add extension support to sign CSR#179
Merged
Conversation
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
WashingtonKK
reviewed
Oct 2, 2025
WashingtonKK
left a comment
Contributor
There was a problem hiding this comment.
The issued certs still do not have the extra options
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
WashingtonKK
previously approved these changes
Oct 5, 2025
SammyOina
suggested changes
Oct 6, 2025
|
|
||
| allDNSNames := make([]string, 0) | ||
| allDNSNames = append(allDNSNames, existingDNSNames...) | ||
| useVerbatim := len(csrData.Extensions) > 0 |
Contributor
There was a problem hiding this comment.
this should always be true not just if there are extensions, cert should have all csr details
|
|
||
| allDNSNames := make([]string, 0) | ||
| allDNSNames = append(allDNSNames, existingDNSNames...) | ||
| useVerbatim := len(csrData.Extensions) > 0 |
Contributor
There was a problem hiding this comment.
this should always be true not just if there are extensions, cert should have all csr details
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes