This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Add intermediate certificates#161
Merged
dborovcanin merged 23 commits intoSep 19, 2025
Merged
Conversation
SammyOina
previously approved these changes
Sep 15, 2025
WashingtonKK
previously approved these changes
Sep 15, 2025
dborovcanin
suggested changes
Sep 15, 2025
d6b9bda
dborovcanin
suggested changes
Sep 17, 2025
dborovcanin
left a comment
Contributor
There was a problem hiding this comment.
Can we use cluent.Logical for handling generic read/write interface; i.e. avoid using custom HTTP client because of tokens, retries, and OpenBao custom headers?
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
WashingtonKK
suggested changes
Sep 18, 2025
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
d6b9bda to
b7aed73
Compare
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
suggested changes
Sep 18, 2025
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
SammyOina
previously approved these changes
Sep 18, 2025
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
6eeab4e
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
57afc7c to
e825f05
Compare
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
suggested changes
Sep 19, 2025
|
|
||
| func (sdk mgSDK) ViewCA(domainID, token string) (Certificate, errors.SDKError) { | ||
| url := fmt.Sprintf("%s/%s/%s/view-ca", sdk.certsURL, domainID, certsEndpoint) | ||
| func (sdk mgSDK) ViewCA() (Certificate, errors.SDKError) { |
Contributor
There was a problem hiding this comment.
Why are we removing token from here?
Contributor
Author
There was a problem hiding this comment.
@WashingtonKK requested to remove users auth from viewCA and downloadCA because of his work on prism.
|
|
||
| func (sdk mgSDK) DownloadCA(domainID, token string) (CertificateBundle, errors.SDKError) { | ||
| url := fmt.Sprintf("%s/%s/%s/download-ca", sdk.certsURL, domainID, certsEndpoint) | ||
| func (sdk mgSDK) DownloadCA() (CertificateBundle, errors.SDKError) { |
Contributor
There was a problem hiding this comment.
Same here, why are we removing access control from SDK methods?
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
approved these changes
Sep 19, 2025
WashingtonKK
approved these changes
Sep 19, 2025
WashingtonKK
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes