This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Add TTL option#15
Merged
Merged
Conversation
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
6796cef to
8d4a335
Compare
dborovcanin
suggested changes
Sep 11, 2024
Comment on lines
+94
to
+102
| var validity time.Duration | ||
| if ttl != "" { | ||
| validity, err = time.ParseDuration(ttl) | ||
| if err != nil { | ||
| return "", errors.Wrap(ErrMalformedEntity, err) | ||
| } | ||
| } else { | ||
| validity = certValidityPeriod | ||
| } |
Contributor
There was a problem hiding this comment.
Use full stop in the comment and update to something like:
Suggested change
| var validity time.Duration | |
| if ttl != "" { | |
| validity, err = time.ParseDuration(ttl) | |
| if err != nil { | |
| return "", errors.Wrap(ErrMalformedEntity, err) | |
| } | |
| } else { | |
| validity = certValidityPeriod | |
| } | |
| // Parse the TTL if provided, otherwise use the default certValidityPeriod. | |
| validity := certValidityPeriod | |
| if ttl != "" { | |
| if validity, err = time.ParseDuration(ttl); err != nil { | |
| return "", errors.Wrap(ErrMalformedEntity, err) | |
| } | |
| } |
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: it add time to live as an option when issuing certs.
What does this do?
It introduces the option to change time duration of a certificate to live.
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
Yes
Did you document any new/modified features?
No, will be done in a different PR.
Notes