This repository was archived by the owner on Apr 6, 2026. It is now read-only.
AMCERTS-148 - Replace PKI with Openbao#142
Merged
Merged
Conversation
0cd2a6e to
3c72953
Compare
48ead4f to
47e4eed
Compare
Contributor
|
@nyagamunene Please rebase. |
47e4eed to
49b89aa
Compare
Contributor
|
@nyagamunene Please rebase. |
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
eb962bd to
6df99cc
Compare
WashingtonKK
suggested changes
Aug 29, 2025
WashingtonKK
left a comment
Contributor
There was a problem hiding this comment.
OCSP fails
So does renew certs
felixgateru
suggested changes
Sep 1, 2025
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
WashingtonKK
approved these changes
Sep 3, 2025
WashingtonKK
suggested changes
Sep 3, 2025
WashingtonKK
left a comment
Contributor
There was a problem hiding this comment.
- Fix tests
- Update mocks
SammyOina
suggested changes
Sep 3, 2025
| return json.NewEncoder(w).Encode(response) | ||
| } | ||
|
|
||
| func encodeOSCPResponse(_ context.Context, w http.ResponseWriter, response interface{}) error { |
WashingtonKK
suggested changes
Sep 3, 2025
| defType = 1 | ||
| ) | ||
|
|
||
| type responseASN1 struct { |
WashingtonKK
reviewed
Sep 3, 2025
| r.Post("/ocsp", otelhttp.NewHandler(kithttp.NewServer( | ||
| ocspEndpoint(svc), | ||
| decodeOCSPRequest, | ||
| encodeOSCPResponse, |
| return lm.svc.ViewCert(ctx, serialNumber) | ||
| } | ||
|
|
||
| func (lm *loggingMiddleware) OCSP(ctx context.Context, serialNumber string) (cert *certs.Certificate, ocspStatus int, rootCACert *x509.Certificate, err error) { |
Contributor
Author
There was a problem hiding this comment.
Revert
This might be hard since openbao doesn't have an OCSP endpoint and from the rootCA we cant get the crypto.Signer to create the ocsp
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Contributor
|
@nyagamunene CI is failing. |
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
SammyOina
approved these changes
Sep 4, 2025
SammyOina
previously approved these changes
Sep 4, 2025
WashingtonKK
previously approved these changes
Sep 4, 2025
Contributor
|
Please fix tests @nyagamunene |
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
f4c1bd9
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
WashingtonKK
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes