This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Update internal server to use supermq#141
Merged
Conversation
SammyOina
suggested changes
Aug 12, 2025
|
|
||
| "github.com/absmach/certs/internal/certs" | ||
| "github.com/absmach/certs/internal/server" | ||
| "github.com/absmach/supermq/pkg/server" |
Contributor
There was a problem hiding this comment.
if internal/server is no longer used, please delete it
Contributor
Author
There was a problem hiding this comment.
Counter checking.
SammyOina
suggested changes
Aug 12, 2025
Contributor
There was a problem hiding this comment.
we can import this from supermq this file entirely, so we can delete here
SammyOina
suggested changes
Aug 12, 2025
Contributor
There was a problem hiding this comment.
if they are not in smq internal package
Contributor
Author
|
Refactored. |
SammyOina
previously approved these changes
Aug 13, 2025
adaee3a to
6907fdc
Compare
Signed-off-by: Jilks Smith <smithjilks@gmail.com>
6907fdc to
d2ec018
Compare
SammyOina
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes