This repository was archived by the owner on Apr 6, 2026. It is now read-only.
NOISSUE - Add ability to revoke all certs for a given entity#107
Merged
Conversation
- Implemented RevokeCerts method in the CertsService interface. - Added gRPC client and server methods for RevokeCerts. - Created request and response message types for RevokeCerts in the protobuf definition. - Updated service implementation to revoke all certificates for a given entity ID. - Enhanced logging and metrics middleware to track RevokeCerts operations. - Added mock implementations for RevokeCerts in the service and client mocks. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
dborovcanin
suggested changes
May 9, 2025
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
WashingtonKK
previously approved these changes
May 13, 2025
dborovcanin
suggested changes
May 13, 2025
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
dborovcanin
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature
What does this do?
Revoke certs for a given entity, required during removal of the entity
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes