Update builtin types according to spec#1029
Merged
benwilson512 merged 3 commits intoabsinthe-graphql:masterfrom Jan 12, 2021
Merged
Update builtin types according to spec#1029benwilson512 merged 3 commits intoabsinthe-graphql:masterfrom
benwilson512 merged 3 commits intoabsinthe-graphql:masterfrom
Conversation
benwilson512
approved these changes
Jan 12, 2021
Contributor
benwilson512
left a comment
There was a problem hiding this comment.
Excellent work as always, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some mismatches between the builtin types and the spec (https://spec.graphql.org/draft/#sec-Schema-Introspection), this PR fixes those.
Also adds the schema description to SDL rendering and introspection, see graphql/graphql-spec#466