build: attempting to fix https://github.com/abseil/abseil-cpp/issues/326#1306
Closed
alyssawilk wants to merge 2 commits intoabseil:masterfrom
Closed
build: attempting to fix https://github.com/abseil/abseil-cpp/issues/326#1306alyssawilk wants to merge 2 commits intoabseil:masterfrom
alyssawilk wants to merge 2 commits intoabseil:masterfrom
Conversation
Author
|
Alternately cl/485404590 but the presubmits tell me to do OSS first and https://github.com/abseil/abseil-cpp/blob/0064d9db90d32d35e9f9d70e2df4ddf8d0ab1257/CONTRIBUTING.md tell me to do google3 first. I'm happy to do either and help reconcile the documentation if y'all tell me what's actually correct. |
Member
|
Sorry, the presubmit message is confusing. Changes to this code need to go to https://github.com/google/cctz. Abseil imports it from there. |
Member
|
Re-opening this so the CI will run. |
Author
|
oh sorry the change is slightly different in cctz now - pushed the latest |
Author
|
closing now we verified CI :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326