Imported modules should be cached / a singleton, closes #427#428
Merged
Conversation
With this change, a module that's been imported is now cached.
This means that every time you call `require('module')` you will
receive back the same evaluated result, meaning changes you make
on that result will be persisted. This only applies to `require`
and not `source`, as `source` is intended to be used in order to
always evaluate a block of fresh code in the current environment.
Before:
```
$ require('@runtime').name = "xxx"
$ require('@runtime').name
abs
```
After:
```
$ require('@runtime').name = "xxx"
$ require('@runtime').name
xxx
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, a module that's been imported is now cached.
This means that every time you call
require('module')you willreceive back the same evaluated result, meaning changes you make
on that result will be persisted. This only applies to
requireand not
source, assourceis intended to be used in order toalways evaluate a block of fresh code in the current environment.
Before:
After: