chore: move to using dependency-groups#227
Conversation
fbf772f to
3913348
Compare
1fd6eb3 to
55228d8
Compare
48d232b to
6606d3a
Compare
| validate_pyproject = "validate_pyproject.repo_review:repo_review_families" | ||
| [tool.uv] | ||
| environments = [ | ||
| "python_version >= '3.9'", |
There was a problem hiding this comment.
FYI, this is required because uv locks across the entire environment, and the docs requirements require 3.9 (sphinx>=7.2.2). You can't build the docs on 3.8.
There was a problem hiding this comment.
Thank you very much @henryiii for working on this. I looks great.
I just wanted to clarify a couple of points (no change in code necessary):
- The improvement in speed in due to
uvright? Or isdependency-groupsinherently faster? - The (reasonable) assumption is that no-one is really installing installing
validate-pyproject[test], so it is fine to remove this extra; right?
Would something like the following work as a CHANGELOG entry (to inform downstream package systems that might not be using tox for the tests)?
validate-pyprojectno longer communicates test dependencies via thetestsextra and doc dependencies via thedocs/requirements.txtfiles. Instead newdependency-groupshave been setup to support CI environments.
(Please feel free to suggest something different)
That's fine, though you could also add more detail:
|
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
6606d3a to
d3a000a
Compare
Trying something new for RtD, based on recent additions. readthedocs/readthedocs.org#11289 Also using tox-uv to speed up CI. This has the added bonus that
uv run pytestalso just works out of the box, since it picks up thedevdependency group. (Note: uv is not required for people running tox, though, just the minimum version was bumped a bit, no other changes for users)This cuts the readthedocs job time in half. Other jobs are faster, too.