Skip to content

feat: add support for loading extra schemas#226

Merged
abravalheri merged 1 commit into
abravalheri:mainfrom
henryiii:henryiii/feat/extra
Feb 25, 2025
Merged

feat: add support for loading extra schemas#226
abravalheri merged 1 commit into
abravalheri:mainfrom
henryiii:henryiii/feat/extra

Conversation

@henryiii

@henryiii henryiii commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

Should fix our tests, too. Needs some tests. There's a new --extra flag that loads an extra schema and the --store support will look for one level of nested schemas and load them as extras.

Alternate fix to #225.

@henryiii henryiii force-pushed the henryiii/feat/extra branch 3 times, most recently from 1a491f9 to 587456c Compare February 6, 2025 22:51
@henryiii henryiii closed this Feb 6, 2025
@henryiii henryiii reopened this Feb 6, 2025
@henryiii henryiii closed this Feb 7, 2025
@henryiii henryiii reopened this Feb 7, 2025
@henryiii henryiii force-pushed the henryiii/feat/extra branch 3 times, most recently from 1c15b4c to 1d2002b Compare February 7, 2025 20:32
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/feat/extra branch from 1d2002b to 25a3e16 Compare February 8, 2025 04:27
@henryiii

henryiii commented Feb 8, 2025

Copy link
Copy Markdown
Collaborator Author

There's another way to do this - we could support empty tool names. This impl. is nearly that already, so maybe it would be simpler to not add a new option, but just allow empty tool names? @abravalheri, thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants