Remove MyPy ignore directive#187
Conversation
92e2f35 to
89562bd
Compare
89562bd to
a9cabc0
Compare
|
Thank you @DimitriPapadopoulos. Do you know if there is an automatic way of removing directives previously needed by |
|
As a starting point, I suggest some of these Repo-Review suggestions (that's where this PR comes from). I can prepare a PR. I have no experience with mypy-upgrade. |
I think some of these are fine, but others might too much for this repo (like prettier or custom pre-commit message). Does |
I was thinking of the settings related to MyPy only, and then only those that aren't too invasive. See #191.
Yes, according to Features (but again I don't have any experience with it):
|
|
Actually, I wonder whether repo-review uses |
|
sp-repo-review only looks at configuration files. Generally repo-review plugins are recommended to process configuration files, and aren't encouraged to look at source files. (The WebAssembly version has to fetch each file, so limiting access is encouraged). |
|
Indeed, I got it all mixed up. I meant that the MyPy changes suggested by repo-review end up in the same suggestions as mypy-update. So the additional MyPy options seem equivalent to mypy-update. |
No description provided.