Skip to content

Patch MudBlazor ripple cleanup for Blazor SSR / InteractiveAuto#25586

Merged
ismcagdas merged 1 commit into
rel-10.4from
maliming/patch-mud-ripple-cleanup
Jun 9, 2026
Merged

Patch MudBlazor ripple cleanup for Blazor SSR / InteractiveAuto#25586
ismcagdas merged 1 commit into
rel-10.4from
maliming/patch-mud-ripple-cleanup

Conversation

@maliming

@maliming maliming commented Jun 9, 2026

Copy link
Copy Markdown
Member

In Blazor Server / WebApp / InteractiveAuto modes, MudBlazor's Ripple JS loses its _mudRipples Map when Blazor re-renders the click target, so mud-ripple-effect spans never get cleaned up and accumulate as gray splotches on nav-links / tabs / buttons. Add an abp-mud-ripple-patch.js MutationObserver that fades and removes stale ripples 600ms after creation. Tracks upstream MudBlazor/MudBlazor#12128.

@maliming maliming added this to the 10.4-patch milestone Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (feffa45) to head (1a48fe2).
⚠️ Report is 17 commits behind head on rel-10.4.

Additional details and impacted files
@@            Coverage Diff            @@
##           rel-10.4   #25586   +/-   ##
=========================================
  Coverage     49.38%   49.38%           
=========================================
  Files          3671     3671           
  Lines        123885   123885           
  Branches       9470     9470           
=========================================
+ Hits          61177    61179    +2     
- Misses        60875    60885   +10     
+ Partials       1833     1821   -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming requested a review from ismcagdas June 9, 2026 06:30
@ismcagdas ismcagdas merged commit f097798 into rel-10.4 Jun 9, 2026
4 checks passed
@ismcagdas ismcagdas deleted the maliming/patch-mud-ripple-cleanup branch June 9, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants