Use IsDeleted column TypeMapping in soft-delete DbFunction#25570
Merged
EngincanV merged 1 commit intoJun 8, 2026
Conversation
EngincanV
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The soft-delete DbFunction translator built the right-hand
falseliteral with the bool TypeMapping, ignoring anyValueConverteron theIsDeletedcolumn. WithHasConversion<int>()(the reproduction in #25567) the generated SQL ends up comparing an int column against the raw bool literal —WHERE is_deleted = FALSEon PostgreSQL — instead of the converter's provider value (0). Switched the literal to use the column's TypeMapping.Closes #25567.