Skip to content

Render attached component in Basic theme user menu#25569

Merged
enisn merged 2 commits into
rel-10.4from
maliming/fix-basic-theme-usermenu-component
Jun 8, 2026
Merged

Render attached component in Basic theme user menu#25569
enisn merged 2 commits into
rel-10.4from
maliming/fix-basic-theme-usermenu-component

Conversation

@maliming

@maliming maliming commented Jun 8, 2026

Copy link
Copy Markdown
Member

Mirror LeptonX Lite's GetComponentTypeOrDefault() check in Basic theme's LoginDisplay.razor (4 variants: Server/WebAssembly × Bootstrap/MudBlazor) so menu items attached via UseComponent(...) render correctly. Without this, Account.BackToImpersonator is rendered as a GET link and hits OpenIddict as an authorization request, failing with ID2029.

@maliming maliming added this to the 10.4-patch milestone Jun 8, 2026
@maliming maliming requested a review from enisn June 8, 2026 02:46
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (a4b170e) to head (feffa45).
⚠️ Report is 5 commits behind head on rel-10.4.

Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.4   #25569      +/-   ##
============================================
- Coverage     49.38%   49.38%   -0.01%     
============================================
  Files          3671     3671              
  Lines        123880   123885       +5     
  Branches       9470     9470              
============================================
- Hits          61179    61177       -2     
- Misses        60867    60875       +8     
+ Partials       1834     1833       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enisn enisn merged commit 50480b1 into rel-10.4 Jun 8, 2026
3 checks passed
@enisn enisn deleted the maliming/fix-basic-theme-usermenu-component branch June 8, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants