Use CLR property name in soft-delete and multi-tenant filters#25568
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rel-10.5 #25568 +/- ##
============================================
- Coverage 49.41% 49.38% -0.03%
============================================
Files 3674 3682 +8
Lines 124053 124249 +196
Branches 9481 9494 +13
============================================
+ Hits 61303 61363 +60
- Misses 60911 61046 +135
- Partials 1839 1840 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EngincanV
approved these changes
Jun 8, 2026
…elete-filter-property-name # Conflicts: # framework/test/Volo.Abp.EntityFrameworkCore.Tests/Volo/Abp/EntityFrameworkCore/TestMigrationsDbContext.cs # framework/test/Volo.Abp.EntityFrameworkCore.Tests/Volo/Abp/TestApp/EntityFrameworkCore/TestAppDbContext.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateFilterExpressioninAbpDbContextpassedGetColumnName()toEF.Property<T>(e, "..."), but the second argument must be the CLR property name. RenamingIsDeleted/TenantIdviaHasColumnName(...)before the filter is registered (and withUseDbFunction = false) made the query fail to translate. Switched toIProperty.Name. Added regression tests for both interfaces.