Remove redundant FallbackToProvider call in MedallionAbpDistributedLock#25497
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up MedallionAbpDistributedLock.TryAcquireAsync by removing a redundant standalone call to CancellationTokenProvider.FallbackToProvider(cancellationToken) whose return value was discarded, while preserving the actual used call passed into TryAcquireLockAsync (resolving #25496).
Changes:
- Removed an unused standalone invocation of
FallbackToProvider(...)inTryAcquireAsync. - Kept the single, effective
FallbackToProvider(...)call used as the cancellation token argument for lock acquisition.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #25497 +/- ##
==========================================
+ Coverage 49.40% 49.41% +0.01%
==========================================
Files 3670 3670
Lines 123599 123599
Branches 9453 9453
==========================================
+ Hits 61068 61081 +13
+ Misses 60711 60683 -28
- Partials 1820 1835 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EngincanV
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the standalone
CancellationTokenProvider.FallbackToProvider(cancellationToken)call inMedallionAbpDistributedLock.TryAcquireAsyncwhose return value was discarded. The same call is made again on the next line as the argument toTryAcquireLockAsync, andFallbackToProvideris a pure extension method with no side effects.Resolves #25496