Skip to content

Restore Data binding on tenant management data grid#25435

Merged
yagmurcelk merged 1 commit into
rel-10.4from
maliming/fix-22330-tenant-grid-refresh
May 14, 2026
Merged

Restore Data binding on tenant management data grid#25435
yagmurcelk merged 1 commit into
rel-10.4from
maliming/fix-22330-tenant-grid-refresh

Conversation

@maliming

Copy link
Copy Markdown
Member

The <AbpExtensibleDataGrid> on the Blazorise tenant management page lost its Data="@Entities" binding in #25235, so the grid never re-renders with the refreshed Entities collection after create/update/delete and the page only shows the new row after a manual refresh.

Identity RoleManagement.razor / UserManagement.razor keep the binding and work as expected; this restores the same binding on TenantManagement.razor.

Fixes volosoft/volo#22330

@maliming maliming requested review from Copilot and yagmurcelk May 14, 2026 08:36
@maliming maliming added this to the 10.4-final milestone May 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the missing Data binding on the tenant management Blazorise <AbpExtensibleDataGrid> so the grid re-renders when the underlying Entities collection is refreshed after CRUD operations, aligning behavior with Identity’s role/user management pages.

Changes:

  • Re-add Data="@Entities" to the tenant management data grid to ensure UI updates after create/update/delete.

@yagmurcelk yagmurcelk merged commit 6b87900 into rel-10.4 May 14, 2026
6 checks passed
@yagmurcelk yagmurcelk deleted the maliming/fix-22330-tenant-grid-refresh branch May 14, 2026 09:00
@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.30%. Comparing base (da24e5e) to head (dd0d9ad).
⚠️ Report is 344 commits behind head on rel-10.4.

Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.4   #25435      +/-   ##
============================================
+ Coverage     49.29%   49.30%   +0.01%     
============================================
  Files          3668     3668              
  Lines        123343   123343              
  Branches       9424     9424              
============================================
+ Hits          60797    60816      +19     
+ Misses        60722    60702      -20     
- Partials       1824     1825       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants