Implement rate limiting in NuGet package push script to manage push f…#25388
Merged
Conversation
…requency and enhance error handling for 4xx responses by parsing retry-after values.
voloagent
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the NuGet package push automation script to better handle NuGet.org throttling by adding a per-hour push rate limiter and honoring server-provided retry after guidance during 4xx retries.
Changes:
- Added a sliding-window rate limiter to cap pushes per hour.
- Enhanced 4xx retry handling to parse and use NuGet’s
retry after: <seconds>svalue when present. - Renamed the static retry delay array to
$defaultQuotaRetryDelaysInSeconds.
Comment on lines
+39
to
+43
| $pushTimestamps = [System.Collections.Generic.List[datetime]]$recentPushes | ||
|
|
||
| if ($pushTimestamps.Count -ge $maxPushesPerHour) | ||
| { | ||
| $waitUntil = $pushTimestamps[0].AddHours(1) |
Comment on lines
+76
to
+80
| $retryAfterMatch = ($pushOutput | Out-String) | Select-String -Pattern 'retry after:\s*(\d+)s' -AllMatches | ||
| if ($retryAfterMatch -and $retryAfterMatch.Matches.Count -gt 0) | ||
| { | ||
| $retryDelay = [int]$retryAfterMatch.Matches[0].Groups[1].Value | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.