Fix localization for SavedSuccessfully in feature management MVC notification#25286
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing localization fallback in the Feature Management MVC/Web module so common UI messages (e.g., SavedSuccessfully) resolve via AbpUiResource instead of showing the raw key, particularly in gateway/microservice setups that reference only HttpApi.Client.
Changes:
- Adds
AbpUiResourceas a base type forAbpFeatureManagementResourceinAbpFeatureManagementWebModule. - Adds required
usingdirectives to support the new localization configuration.
yagmurcelk
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After saving the "Manage host features" modal in the MVC UI, the success notification shows the raw key
SavedSuccessfullyinstead of the translated text.SavedSuccessfullyis defined inAbpUiResource, not inAbpFeatureManagementResource. TheHttpApiandBlazormodules already registerAbpUiResourceas a base type, but the MVCWebmodule does not. In microservice setups where the web gateway only referencesHttpApi.Client(notHttpApi), the base type is missing and the lookup falls back to the key name.Add
AddBaseTypes(typeof(AbpUiResource))inAbpFeatureManagementWebModule, matching howAbpPermissionManagementWebModule,AbpAuditLoggingWebModule,AbpOpenIddictProWebModuleand other Web modules do it.Resolves https://github.com/volosoft/volo/issues/22171