Serialize complex objects in exception data logging#25267
Merged
Conversation
Use JsonSerializer for non-primitive types in AbpLoggerExtensions.LogData to output meaningful JSON instead of type names like List`1[Dictionary`2[...]]
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ABP’s exception data logging to output meaningful content when Exception.Data contains complex objects by JSON-serializing non-primitive values, and adds unit tests to validate the formatting behavior.
Changes:
- Serialize non-primitive
Exception.Datavalues to JSON inAbpLoggerExtensions.LogExceptionlogging output, with fallback toToString()on serialization failure. - Add unit tests covering formatting of string/primitive/enum/Guid/DateTime/null and complex object/list values in exception data.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| framework/src/Volo.Abp.Core/Microsoft/Extensions/Logging/AbpLoggerExtensions.cs | Adds FormatDataValue and uses JsonSerializer.Serialize to log complex Exception.Data values as JSON. |
| framework/test/Volo.Abp.Core.Tests/Microsoft/Extensions/Logging/AbpLoggerExtensions_Tests.cs | Introduces tests validating the new exception data formatting behavior for multiple value types. |
EngincanV
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exception.Data contains complex objects (e.g. List<Dictionary<string, object>>), LogData outputs the type name instead of actual content. This uses JsonSerializer for non-primitive types to produce meaningful JSON output in logs, with a fallback to ToString() if serialization fails.