fix(mvc): skip abpAjaxForm submission when default is already prevented#25260
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the previous jquery-form plugin behavior in abpAjaxForm by skipping AJAX submission when another submit handler has already prevented the default action, avoiding unintended duplicate POSTs (notably in modal forms with custom submit logic).
Changes:
- Added an early
e.isDefaultPrevented()guard in thesubmit.abpAjaxFormhandler to exit without performing AJAX submission. - Preserved existing
preventDefault()behavior for normalabpAjaxForm-handled submissions.
EngincanV
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the jquery-form plugin was replaced with a custom
abpAjaxFormimplementation, theisDefaultPrevented()check was lost. The old plugin skipped submission if another handler had already calledpreventDefault(), but the new implementation always proceeds unconditionally.This caused issues for modal forms with custom submit handlers (e.g.
DelegateNewUserFormin Authority Delegation), where both the custom handler andabpAjaxFormwould fire, resulting in an unwanted extra POST towindow.location.href.This restores the old jquery-form plugin's behavior by checking
e.isDefaultPrevented()before proceeding.