Increase AbpMemoryPoolHttpResponseStreamWriterFactory buffer size to 256KB#25253
Merged
Merged
Conversation
…m 32KB to 256KB Prevents 'Synchronous operations are disallowed' error when rendering large MVC views (e.g. Account settings page with multiple tabs in non-English locales).
EngincanV
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the default buffer size used by ABP’s custom IHttpResponseStreamWriterFactory implementation to reduce the likelihood of MVC view rendering triggering a synchronous flush (and the associated InvalidOperationException when synchronous I/O is disallowed).
Changes:
- Increase
AbpMemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSizefrom 32KB to 256KB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the default buffer size of
AbpMemoryPoolHttpResponseStreamWriterFactoryfrom 32KB to 256KB.When rendering large MVC views (e.g. Account settings page with multiple tabs in non-English locales), the 32KB buffer overflows during
ViewBuffer.WriteToAsync, triggering a synchronous flush toHttpResponseStream.Writewhich throwsInvalidOperationException: Synchronous operations are disallowed.Since the buffer is backed by
ArrayPool, the increased size has negligible memory impact.