Use HttpPost for PermissionIntegrationController.IsGrantedAsync#25177
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Switches the Permission Management integration permission-check endpoint to use POST so large List<IsGrantedRequest> payloads are sent in the request body instead of the query string (avoiding URL length limits). This aligns the integration API with typical request sizing constraints and the generated client proxy metadata.
Changes:
- Change
PermissionIntegrationController.IsGrantedAsyncfrom[HttpGet]to[HttpPost]. - Update the generated client proxy description (
permissionManagement-generate-proxy.json) to usePOSTand bindinputfrom the request body.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/permission-management/src/Volo.Abp.PermissionManagement.HttpApi/Volo/Abp/PermissionManagement/Integration/PermissionIntegrationController.cs | Switch the is-granted endpoint to POST to move payload into request body. |
| modules/permission-management/src/Volo.Abp.PermissionManagement.HttpApi.Client/ClientProxies/permissionManagement-generate-proxy.json | Regenerate proxy metadata to use POST and Body binding for input. |
EngincanV
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IsGrantedAsyncendpoint was using[HttpGet], which requires passingList<IsGrantedRequest>via query string and can easily exceed URL length limits when checking multiple users and permissions.Changed to
[HttpPost]so the payload is sent in the request body.Closes #25175