Upgrade Scriban to 7.0.0#25170
Merged
Merged
Conversation
acd24ac to
4f204fa
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the Scriban dependency used by ABP’s Scriban-based text templating integration to resolve a known DoS vulnerability and prevent runtime TypeLoadException issues when consuming Scriban 7.x.
Changes:
- Bumped Scriban NuGet package from 6.6.0 to 7.0.0 via central package management.
- Updated
ScribanTemplateLocalizerto match Scriban 7’s nullable-annotatedIScriptCustomFunctionsignatures. - Updated package version change documentation to include the Scriban bump.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| framework/src/Volo.Abp.TextTemplating.Scriban/Volo/Abp/TextTemplating/Scriban/ScribanTemplateLocalizer.cs | Adapts to Scriban 7 nullability changes and fixes argument array typing for IStringLocalizer. |
| docs/en/package-version-changes.md | Records dependency version changes for release notes / tracking. |
| Directory.Packages.props | Central package version bump for Scriban to 7.0.0. |
Comments suppressed due to low confidence (1)
docs/en/package-version-changes.md:27
- The Scriban package upgrade to 7.0.0 (see Directory.Packages.props) isn’t reflected in the
10.3.0-rc.1table here. Please add a row documenting the version change (6.6.0 -> 7.0.0) in this section so the published package version change log stays accurate.
|---------|-------------|-------------|-----|
| Scriban | 6.3.0 | 6.6.0 | #25122 |
## 10.2.0-rc.1
| Package | Old Version | New Version | PR |
|---------|-------------|-------------|-----|
| MongoDB.Driver | 3.6.0 | 3.7.0 | #25003 |
## 10.2.0-preview
| Package | Old Version | New Version | PR |
|---------|-------------|-------------|-----|
| Blazorise | 1.8.8 | 2.0.0 | #24906 |
| Blazorise.Components | 1.8.8 | 2.0.0 | #24906 |
| Blazorise.DataGrid | 1.8.8 | 2.0.0 | #24906 |
ebicoglu
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Scriban from 6.6.0 to 7.0.0 to fix security vulnerability GHSA-v66j-x4hw-fv9g (DoS via
string.pad_left/string.pad_rightwithout width validation).Scriban 7.0.0 changed
ParserOptionsandLexerOptionsfromstructtorecord, which also adds nullable annotations toIScriptCustomFunctioninterface. UpdatedScribanTemplateLocalizerto match the new interface signatures.Users who previously tried to override Scriban to 7.0.0 encountered a
TypeLoadExceptiondue to the value type mismatch between the ABP NuGet package (compiled against 6.x) and Scriban 7.0.0 at runtime. This upgrade resolves that issue.