Refine target branch detection in update-studio-docs workflow#25166
Merged
Conversation
Updated target branch handling in workflow to allow auto-detection from the latest stable ABP release if not provided.
voloagent
approved these changes
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the update-studio-docs GitHub Actions workflow so the target branch can be left empty and auto-detected based on the latest stable ABP Framework release, instead of defaulting to dev.
Changes:
- Allow
target_branchto be empty and introduce an auto-detection step that derivesrel-X.Yfrom the latest stable ABP release tag. - Update downstream steps (validation, checkout, PR creation/summary) to use the resolved target branch output.
- Add a default reviewer (
skoc10) when creating/updating the docs PR.
Comment on lines
+77
to
+81
| RELEASES=$(curl -fsS \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \ | ||
| "https://api.github.com/repos/abpframework/abp/releases?per_page=20") | ||
|
|
There was a problem hiding this comment.
This workflow now fetches ABP releases twice (here in Resolve target branch, and later in Fetch latest stable ABP version) with essentially the same filter logic. That’s duplicated logic to maintain, adds an extra API call, and can produce inconsistent results if a new ABP release is published between the two steps. Consider fetching the latest stable ABP version once early and reusing it both to derive TARGET_BRANCH and to set ABP_VERSION later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.