fix(cli): use ToUpperInvariant for snake case replacement in SolutionRenamer#25128
Merged
Merged
Conversation
|
|
Contributor
Author
|
Hi, this is my first contribution. Please let me know if any changes are needed. Thank you! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes culture-sensitive casing during solution/module renaming in the ABP CLI by switching snake_case placeholder replacement from ToUpper() to ToUpperInvariant(), preventing incorrect results on locales like Turkish (e.g., module names containing i).
Changes:
- Updated snake_case rename replacements in
SolutionRenamerto useToUpperInvariant()for deterministic casing across environments.
Member
|
Thanks @JasonPG2007 👍 |
maliming
approved these changes
Mar 23, 2026
Contributor
Author
My pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
ToUpper()withToUpperInvariant()inSolutionRenamerto avoid culture-sensitive casing issues during project/module name replacement.Why
Issue #24988 reports incorrect Angular route name generation when the module name contains the letter
i, for exampleFinancialOperations.Using
ToUpper()can produce culture-specific results on some systems, whileToUpperInvariant()ensures consistent behavior across environments.Change
Replaced:
_projectNamePlaceHolder.ToSnakeCase().ToUpper()_projectName.ToSnakeCase().ToUpper()With:
_projectNamePlaceHolder.ToSnakeCase().ToUpperInvariant()_projectName.ToSnakeCase().ToUpperInvariant()Notes
The change is isolated and minimal.