Conversation
Introduce a set of JSON Schema definitions to support dashboards and visualizations (aggregation, chart, chart-type, descriptor, filter, group, list, number, position, user-filter, visualization, visualization-type). Update page-descriptor.schema.json to include a dashboard property and a conditional requirement when page type is "dashboard", and extend page-type.schema.json enum to include "dashboard". These changes add schema-level validation for dashboard configuration, visualizations (number/chart/list), positioning, and filters.
Remove entityName from the required fields of dashboard-group-descriptor so group definitions no longer must specify an entity. Add an optional entityName string property to dashboard-visualization-descriptor (minLength: 1) so individual visualizations can override the group's entityName. If the visualization-level entityName is omitted, the group's entityName is used.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the ABP Low-Code model.json JSON Schema (model.schema.json) and all referenced schema definition files, eliminating the schema-based IntelliSense/validation artifact from the repository.
Changes:
- Deleted
lowcode/schema/model.schema.json. - Deleted all
lowcode/schema/definitions/*.schema.jsonfiles that the model schema referenced (entities, forms, pages, endpoints, validators, etc.).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lowcode/schema/model.schema.json | Removes the top-level Low-Code model.json JSON Schema. |
| lowcode/schema/definitions/validator-descriptor.schema.json | Removes schema for validator definitions. |
| lowcode/schema/definitions/page-type.schema.json | Removes schema for supported page types. |
| lowcode/schema/definitions/page-descriptor.schema.json | Removes schema for page descriptors. |
| lowcode/schema/definitions/interceptor-type.schema.json | Removes schema for interceptor timing/type. |
| lowcode/schema/definitions/form-rule-descriptor.schema.json | Removes schema for conditional form rules. |
| lowcode/schema/definitions/form-layout-descriptor.schema.json | Removes schema for form layout (tabs/groups/rows/cells). |
| lowcode/schema/definitions/form-field-type.schema.json | Removes schema for supported form field types. |
| lowcode/schema/definitions/form-field-descriptor.schema.json | Removes schema for form field descriptors. |
| lowcode/schema/definitions/form-descriptor.schema.json | Removes schema for form descriptors. |
| lowcode/schema/definitions/foreign-key-descriptor.schema.json | Removes schema for foreign key descriptors. |
| lowcode/schema/definitions/enum-descriptor.schema.json | Removes schema for JSON-defined enums. |
| lowcode/schema/definitions/entity-ui-descriptor.schema.json | Removes schema for entity UI configuration. |
| lowcode/schema/definitions/entity-property-ui-form-availability.schema.json | Removes schema for property form availability enum. |
| lowcode/schema/definitions/entity-property-ui-descriptor.schema.json | Removes schema for property UI configuration. |
| lowcode/schema/definitions/entity-property-type.schema.json | Removes schema for property type enum. |
| lowcode/schema/definitions/entity-property-descriptor.schema.json | Removes schema for entity property descriptors. |
| lowcode/schema/definitions/entity-descriptor.schema.json | Removes schema for entity descriptors. |
| lowcode/schema/definitions/endpoint-descriptor.schema.json | Removes schema for custom endpoint descriptors. |
| lowcode/schema/definitions/command-interceptor-descriptor.schema.json | Removes schema for command interceptor descriptors. |
Comments suppressed due to low confidence (2)
lowcode/schema/model.schema.json:1
- This change removes
model.schema.json(and related schema definitions), but the documentation still states that this schema file is available for IDE IntelliSense (seedocs/en/low-code/model-json.md). If the schema support is being discontinued, the docs should be updated accordingly; otherwise, please restore the schema files or relocate them and update references so users can still reference$schemainmodel.json.
lowcode/schema/model.schema.json:1 - PR title "Lc dash" doesn’t appear to match the actual change set here (removal of Low-Code JSON schema files). If this PR is intended to deprecate/remove schema-based IntelliSense/validation, please clarify in the PR title/description to make the intent and impact clear for reviewers and release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.