Skip to content

Sorts the files in tableview by their depth in directory tree #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OmkarPh merged 1 commit into from
Jan 22, 2024
Merged

Sorts the files in tableview by their depth in directory tree #625

OmkarPh merged 1 commit into from
Jan 22, 2024

Conversation

@OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Jan 10, 2024

No description provided.

@OmkarPh
Added level field to flatfiles for sorting
ef4febc 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OmkarPh LGTM!

As a side effect, we are having a lot of directories bundled together in the Table view, far from where the files in them are, so these are not very helpful and should we either apply the filter for type as show only files, or only show files in the Table view (I'm not sure if they have some useful context for looking at scans)?
What do you think we should do here?

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Jan 15, 2024

Thanks @OmkarPh LGTM!

As a side effect, we are having a lot of directories bundled together in the Table view, far from where the files in them are, so these are not very helpful and should we either apply the filter for type as show only files, or only show files in the Table view (I'm not sure if they have some useful context for looking at scans)? What do you think we should do here?

Usually, there's not much we understand looking at directories, but we have for_packages value for some directories.
For example, these paths: postgresml-2.8.1/pgml-sdks/pgml/javascript/examples, postgresml-2.8.1/pgml-sdks/pgml/javascript/examples/webpack

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Jan 22, 2024

Merging the PR, let's discuss more based on feedback

@OmkarPh OmkarPh merged commit b5ea739 into develop Jan 22, 2024
@OmkarPh OmkarPh mentioned this pull request Feb 8, 2024
Closed
@pombredanne pombredanne deleted the improve/depth-based-tableview-sort branch December 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OmkarPh @AyanSinhaMahapatra