feat: add PR template #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dotarjun <arjunsingh8112@gmail.com> feat: add PR template Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
Collaborator
|
I'm not sure if we want an elaborated or minimal PR template like scancode-toolkit here |
OmkarPh
requested changes
Dec 6, 2023
Collaborator
OmkarPh
left a comment
There was a problem hiding this comment.
Hey @dotarjun
As discussed in the community call, we want a small and simple PR template like scancode-toolkit I mentioned above
You can use the following text for testing point:
Tests pass -- Run npm test locally to check for errors. Look for a green checkbox ✔️ a few minutes after opening your PR
Collaborator
|
gentle ping @dotarjun |
Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
OmkarPh
requested changes
Feb 5, 2024
Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
Collaborator
|
LGTM, merging |
OmkarPh
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #616